46 one of the post install checks requires gtest to be installed #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 20, 2024 11:39
…quests in a queue pair), not just relying on device information about max_qp_wr, but actually trying to create QPs via ibv_create_qp with different max_send_wr until we find the largest still working number (via binary search). This becomes the updated m_maxSrs. Independently, the 100K element test manyPuts needs to be downgraded to 5K for our cluster, as our count is just over 10K, but actually 10K does not work as well (not sure why?)
…e in manyPuts -- the device does not support having too many messages in the send WR QP
…it is very complicated to fix these tests - they seem all over the place, not working, but commiting it
… (only the minimum) but still have many failing tests without explanation, and not tested at all properly
…in the execute command. Also, reduce some example message count as it does not work with IB Verbs with very large tests on the ARM machine
…ted with the debug subdirectory
…ent logic if the bloody Gtest wants to just list the tests or run them
…ATH, and that should be it
…. Also, using Setup and TearDown for entire test suite now, pretty neat, no code duplication each time
…d remove c99 requirement and turn them into C++ tests
… I need to make MPI engines in debug layer call MPI_Abort, and pthread engine in debug layer call std::abort
…y, while it works, this didn't solve the problem. Mpirun still is used with pthreads, so it changes the std::abort signal to 134. This is why now I changed the launcher. Still having issues with some hybrid tests though.
… actually contaminating the hybrid code
…ap script from pre-existing googletest messages
… which internally is non-portably converted to 134. This also simplifies the launcher script. Also fix some incorrect delete's for arrays in the collectives
…y, we get all tests at the moment via gtest_add_tests. It would be good to replace gtest_add_tests with gtest_discover_tests in the future though, because the current one takes 60-90 seconds to configure. Also, there is a horrible bug now where if I specify a high CMake version (e.g. the needed 3.29.0), the GoogleTests would simply not compile at all
…he processor count and overwriting min/max if needed. Also, delete run.sh which is not used anymore. Also remove a debug message from MPI's abort
…ing for abort.h in the hybrid engine, and finally fix visibility of LPF_HAS_ABORT for hybrid engine
…s input arguments which are not documented anywhere. Also, variants of this test are in the exception list, which might mean this test is not stable.
…chook tests to ensure they don't block each other using the same port
…cs expose the issue, and that number is capped with current CMake.
…before adding it as a target
…use mpirma and mpimsg as fallback in such cases
…ible (even if no IB card is present). With GTest integration now, this is only possible when tests are disabled
…d (finding the header does not need pass by link stage)
… that the variables are populated by dependent engines
…d ensure that the variables are populated by dependent engines" This reverts commit faa3b33.
… which were declared in the MPI directory for the MPI engine, while engines in general also define unit tests that need call add_gtest. We break the cycle by pulling engine-specific cflags into the main CMakeLists.txt
…ll have no test on OS X, but at least we will not break something else for that target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #46