Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore missing translation keys #6317

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Jan 16, 2025

Description

This PR restores several translation keys that were present in commit 92b8d55 but were missing in the current version of the translation file.

Changes

  • Added back CONFIGURATION$SETTINGS_NOT_FOUND with English and Spanish translations
  • Restored CONNECT_TO_GITHUB_BY_TOKEN_MODAL$TERMS_OF_SERVICE (en, es)
  • Restored SESSION$SERVER_CONNECTED_MESSAGE with all language variants

Context

These translations were identified as missing when comparing the current translation file against commit 92b8d55. Restoring them ensures we maintain full internationalization support for all features.

Testing

  • Verified all restored keys match exactly with their previous versions from commit 92b8d55
  • Maintained JSON structure and formatting

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:096eb59-nikolaik   --name openhands-app-096eb59   docker.all-hands.dev/all-hands-ai/openhands:096eb59

@xingyaoww xingyaoww marked this pull request as ready for review January 16, 2025 18:50
@xingyaoww xingyaoww requested a review from raymyers January 16, 2025 18:50
Copy link
Contributor

@raymyers raymyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed these match the translation text and keys from sha 92b8d55c2db6884e7883065a9003fc093903f6c2, which was pre #6070.

@xingyaoww xingyaoww enabled auto-merge (squash) January 16, 2025 19:00
Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@xingyaoww xingyaoww merged commit f8a3aec into main Jan 16, 2025
17 checks passed
@xingyaoww xingyaoww deleted the fix/restore-missing-translations branch January 16, 2025 19:21
csmith49 pushed a commit to csmith49/OpenHands that referenced this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants