Make URLRequest fail gracefully #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-b, can the upload be done in a thread so users don't have to wait for it to complete? |
t-b
force-pushed
the
bugfix/2340-make-url-request-fail-gracefully
branch
from
2d3b50b to
4f60a64
Compare
Done. |
t-b
force-pushed
the
bugfix/2340-make-url-request-fail-gracefully
branch
from
4f60a64 to
21362eb
Compare
timjarsky
reviewed
Feb 5, 2025
This avoids assertions in case the machine has no internet or the other side is down/misconfigured.
This avoids having each caller to care about that.
t-b
force-pushed
the
bugfix/2340-make-url-request-fail-gracefully
branch
from
21362eb to
b6acc0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2164