Prefer Listbox modes with more natural shortcuts #2341
Conversation
This uses more intuitive shortcuts for selecting multiple cells. Although we don't need multiple cells here, it is much easier to use a mode which fill selWave. Which mode 1-2 don't do.
This is more intuitive to use. As that mode sets either LISTBOX_SELECTED or LISTBOX_SHIFT_SELECTION for a seleted cell, we have to adapt the FindIndizes calls to search for that, and also search for it as bitmask.
When loading multiple experiments from the analysis browser, we expect that the total number of sweeps in the display is correct. This was not the case as we used the last sweep number and not the number of sweeps. In addition it was not possible to select sweeps from the popupmenu from later experiments as it always selected the same sweep from the first experiment.
…ion bits This is faster.
This reverts commit 8702208 (AB_GetExpandedIndices: Avoid function call in for loop statement, 2023-03-31). As the comment clearly states we need to recalculate the wave size on each iteration as it might change. This was done to please check-code.sh, so we now also need a NOLINT
|
@t-b testing shows that shift enables the selection of multiple items in a list. The Ctrl behavior is the same as without it. I expected that Ctrl would permit the selection of multiple individual list items, while shift would allow for the selection of multiple grouped or adjacent list items. What is the expected behavior? |
The expected behaviour is that you can select adjacent entries with SHIFT and all other entries with CTRL. You need to reopen the analysis browser for that. |
|
@t-b, is this update limited to the analysis browser, or should other listboxes, like the dashboard, exhibit the same behavior? |
Looks like I missed the dashboard. I'll fix that. |
This is more intuitive to use.
|
@t-b the data browser dashboard is working after the latest changes. Thanks. |
This uses more intuitive shortcuts for selecting multiple cells.
Close #2148