CI: Update ipt #2347
Merged
CI: Update ipt #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
force-pushed
the
feature/2347-update-ipt
branch
2 times, most recently
from
728a51e to
dc6c6b9
Compare
|
Will merge once CI passes. |
t-b
force-pushed
the
feature/2347-update-ipt
branch
2 times, most recently
from
9adc1db to
47b2167
Compare
|
@timjarsky Could you rubber stamp this, so that the automatic merge can kick in overnight? |
timjarsky
previously approved these changes
Feb 11, 2025
For now we disable all the new linters which fail. BugproneLoopInitializationAssignment is already passing.
In both cases we actually wanted to have a free wave were we don't need /O.
t-b
force-pushed
the
feature/2347-update-ipt
branch
from
47b2167 to
9c456af
Compare
The to be fixed cases can fall in three categories: - GUI switch statements for controls and window hooks: We always want to not do anything in the default clause - Cases were we iterated over all possible values, this needs an assertion or a FAIL statement for the tests - Cases were we don't want to do anything for certain values. This is mostly done with a comment.
The new ipt linting rule ReadabilityMissingParenthesis creates code like for(i = oldSize; i < (arrayIndex + 1); i += 1) which is without the fix being complained at.
The tests CheckIfAllControlsReferStateWv and CheckStartupSettings needed to learn that there is nothing to do for the group and the title box.
t-b
force-pushed
the
feature/2347-update-ipt
branch
from
9c456af to
d9733d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add relevant commits toAs the changes are not pure formatting, we don't want to ignore them..git-blame-ignore-revs