Minor: Format code - refs BT#22403

AngelFQC · Feb 18, 2025 · f6c7005 · f6c7005
1 parent 272af46
commit f6c7005
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 46 deletions.
diff --git a/main/exercise/exercise.class.php b/main/exercise/exercise.class.php
@@ -460,7 +460,8 @@ public function updateTextWhenFinished($text)
     }
 
     /**
-     * Get the text to display when the user has failed the test
+     * Get the text to display when the user has failed the test.
+     *
      * @return string html text : the text to display ay the end of the test
      */
     public function getTextWhenFinishedFailure(): string
@@ -473,8 +474,7 @@ public function getTextWhenFinishedFailure(): string
     }
 
     /**
-     * Set the text to display when the user has succeeded in the test
-     * @param string $text
+     * Set the text to display when the user has succeeded in the test.
      */
     public function setTextWhenFinishedFailure(string $text): void
     {
@@ -11837,6 +11837,34 @@ public static function getFeedbackTypeLiteral(int $feedbackType): string
         return $result;
     }
 
+    /**
+     * Return the text to display, based on the score and the max score.
+     *
+     * @param int|float $score
+     * @param int|float $maxScore
+     */
+    public function getFinishText($score, $maxScore): string
+    {
+        if (true !== api_get_configuration_value('exercise_text_when_finished_failure')) {
+            return $this->getTextWhenFinished();
+        }
+
+        $passPercentage = $this->selectPassPercentage();
+
+        if (!empty($passPercentage)) {
+            $percentage = float_format(
+                ($score / (0 != $maxScore ? $maxScore : 1)) * 100,
+                1
+            );
+
+            if ($percentage < $passPercentage) {
+                return $this->getTextWhenFinishedFailure();
+            }
+        }
+
+        return $this->getTextWhenFinished();
+    }
+
     /**
      * Get number of questions in exercise by user attempt.
      *
@@ -12322,32 +12350,4 @@ private function setResultDisabledGroup(FormValidator $form)
             get_lang('ShowResultsToStudents')
         );
     }
-
-    /**
-     * Return the text to display, based on the score and the max score.
-     * @param int|float $score
-     * @param int|float $maxScore
-     * @return string
-     */
-    public function getFinishText($score, $maxScore): string
-    {
-        if (true !== api_get_configuration_value('exercise_text_when_finished_failure')) {
-            return $this->getTextWhenFinished();
-        }
-
-        $passPercentage = $this->selectPassPercentage();
-
-        if (!empty($passPercentage)) {
-            $percentage = float_format(
-                ($score / (0 != $maxScore ? $maxScore : 1)) * 100,
-                1
-            );
-
-            if ($percentage < $passPercentage) {
-                return $this->getTextWhenFinishedFailure();
-            }
-        }
-
-        return $this->getTextWhenFinished();
-    }
 }
diff --git a/main/exercise/exercise_show.php b/main/exercise/exercise_show.php
@@ -379,7 +379,6 @@ function getFCK(vals, marksid) {
     $questionList = $question_list_from_database;
 }
 
-
 // for each question
 $total_weighting = 0;
 foreach ($questionList as $questionId) {

diff --git a/main/inc/lib/exercise.lib.php b/main/inc/lib/exercise.lib.php
@@ -5840,20 +5840,6 @@ public static function getSessionWhenFinishedFailure(int $exerciseId): ?SessionE
         return null;
     }
 
-    private static function subscribeSessionWhenFinishedFailure(int $exerciseId): void
-    {
-        $failureSession = self::getSessionWhenFinishedFailure($exerciseId);
-
-        if ($failureSession) {
-            SessionManager::subscribeUsersToSession(
-                $failureSession->getId(),
-                [api_get_user_id()],
-                SESSION_VISIBLE_READ_ONLY,
-                false
-            );
-        }
-    }
-
     /**
      * It validates unique score when all user answers are correct by question.
      * It is used for global questions.
@@ -7416,4 +7402,18 @@ public static function exportExerciseAllResultsZip(
 
         return false;
     }
+
+    private static function subscribeSessionWhenFinishedFailure(int $exerciseId): void
+    {
+        $failureSession = self::getSessionWhenFinishedFailure($exerciseId);
+
+        if ($failureSession) {
+            SessionManager::subscribeUsersToSession(
+                $failureSession->getId(),
+                [api_get_user_id()],
+                SESSION_VISIBLE_READ_ONLY,
+                false
+            );
+        }
+    }
 }
diff --git a/src/Chamilo/CourseBundle/Entity/CQuiz.php b/src/Chamilo/CourseBundle/Entity/CQuiz.php
@@ -853,6 +853,7 @@ public function getTextWhenFinishedFailure(): ?string
     public function setTextWhenFinishedFailure(?string $textWhenFinishedFailure): CQuiz
     {
         $this->textWhenFinishedFailure = $textWhenFinishedFailure;
+
         return $this;
     }
 }