Stop using deprecated functions in the testsuite #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiagoIze
reviewed
Jan 13, 2025
testsuite/test_0148/data/test.cpp
Outdated
| @@ -7,14 +7,14 @@ int main(int argc, char **argv) | |||
| { | |||
| AiMsgSetConsoleFlags(nullptr, AI_LOG_ALL); | |||
| AiBegin(); | |||
| AiSceneLoad(nullptr, "scene.ass", nullptr); | |||
| AiSceneWrite(nullptr, "scene_exported.usda", nullptr); | |||
| AiSceneLoad(nullptr, AtString("scene.ass"), nullptr); | |||
There was a problem hiding this comment.
AiSceneLoad/Write take a const char* filename so not sure there is any benefit to use an AtString like this
sebastienblor
requested review from
ThiagoIze and
cpichard
and removed request for
ThiagoIze
cpichard
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Several cpp tests are calling functions that are marked as deprecated. This PR fixes them