Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

band-aid solution to updating rev sim to 2025 #1118

Open
wants to merge 20 commits into
base: dev
Choose a base branch
from

Conversation

ktvuwhs
Copy link

@ktvuwhs ktvuwhs commented Jan 5, 2025

Description

Modified vendordep JSON files and synthesis.revrobotics wrapper class files to allow Synthesis CAN simulator to work with REVLib 2025.0.0. Compatibility with 2025 was accomplished mainly by commenting out and/or removing code from the wrapper class that previously adhered to 2024 REVLib codebase that had been deprecated and removed from the 2025 codebase, as well as updating JSON files to the correct, 2025 version numbers.

Objectives

  • Allow basic usage of REVLib SparkMax class as CAN sim device.

Testing Done

  • Basic drivebase using Arcade Drive; specifically with 2024 Kitbot
  • Specifically the set() method in the REVLib SparkMax class

JIRA Issue

@ktvuwhs ktvuwhs requested review from HunterBarclay and a team as code owners January 5, 2025 08:48
@ktvuwhs ktvuwhs requested review from BrandonPacewic and Dhruv-0-Arora and removed request for a team January 5, 2025 08:48
@HunterBarclay HunterBarclay changed the base branch from prod to dev January 5, 2025 16:43
@HunterBarclay
Copy link
Member

HunterBarclay commented Jan 5, 2025

@ktvuwhs Thanks for the PR. I'll be submitting some changes to your fork to make sure that this is done completely and we aren't just commenting out all the functionality. I'll probably be making alternative versions of the config classes and then removing most of the functions from SparkMax.java to make sure this more closely aligns with how SparkMaxes are used in 2025. Will probably take me a day or two to find the time.

@HunterBarclay
Copy link
Member

@ktvuwhs ktvuwhs#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants