feat: capitalize multi-word country and capital city names #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's some subjectivity about what's regarded as a country. Some do not fit in either `proper_noun_capitalization.rs` or `matcher.rs` The former capitalizes every word, but some have one minor word that shouldn't be capitalized. I didn't check if that logic is already built in though. The latter expects words separated by spaces only, but some use hyphens. Place names that have an uncapitalized word *and* a hyphen therefor don't fit either. There are some similar cases. We can use hyphen in the former, but periods don't seem to work for places with names like "St. Foo". The latter is case sensitive so I put in 3 case variants of each: all lower, first word caps but not the other words, all words caps including minor words which shouldn't be. For place names that have some other variant such as covering both space and hyphen or with and without accent, this adds up to a lot and it's easy to miss one. Plus any other combination of upper and lower case doesn't get flagged. A linter to handle the most common of these would be better.
elijah-potter
requested changes
Feb 17, 2025
|
In the big "overhaul" I just merged, there were some minor changes to the syntax for proper nouns like these. Take a look at the merge commit to see what it should look like moving forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some subjectivity about what's regarded as a country.
Some do not fit in either
proper_noun_capitalization.rsormatcher.rsThe former capitalizes every word, but some have one minor word that shouldn't be capitalized. I didn't check if that logic is already built in though.The latter expects words separated by spaces only, but some use hyphens.
Place names that have an uncapitalized word and a hyphen therefor don't fit either. There are some similar cases.
We can use hyphen in the former, but periods don't seem to work for places with names like "St. Foo".
The latter is case sensitive so I put in 3 case variants of each: all lower, first word caps but not the other words, all words caps including minor words which shouldn't be.
For place names that have some other variant such as covering both space and hyphen or with and without accent, this adds up to a lot and it's easy to miss one. Plus any other combination of upper and lower case doesn't get flagged.
A linter to handle the most common of these would be better.