Create linter for non-idiomatic "back in the days" #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-potter
force-pushed
the
back-in-the-days
branch
from
60e06df to
56377c1
Compare
Also the unit tests from my version of this lint I was working on yesterday.
I was working on a linter for this one yesterday too and got stuck. I can see that new functionality was indeed needed. I also found another false positive with "Back in the days when ...". I submitted a PR with that change plus all my unit tests to this branch: #712 |
feat: another exception for "back in the days before"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #702.
Two things happened here.
PatternLintertrait to allow cancelling a lint in thematch_lintphase by returningOption::None.