Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms: add date validation to date picker field in all browsers #7888

Open
jeherve opened this issue Sep 28, 2017 · 5 comments · May be fixed by #41698
Open

Forms: add date validation to date picker field in all browsers #7888

jeherve opened this issue Sep 28, 2017 · 5 comments · May be fixed by #41698
Assignees
@enejb
Labels
[Feature] Contact Form Good For Community [Pri] Low [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jeherve
Copy link
Member

jeherve commented Sep 28, 2017 •
edited
Loading

In Firefox and Safari if I type in the date field, instead of using the date picker, I can enter any numbers (e.g. 12345) and submit the form. There’s no date validation.

screenshot 2017-09-28 at 15 48 58

It does not seem to be perfect in Chrome either:

In Chrome if I type in the date field it enforces the date to some extent, but I can enter a 6-digit year (e.g. 01/01/111111). The maximum year value it accepts is 275760, so maybe this is just the maximum year that Chrome accepts? It still seems weird.
@jeherve jeherve added [Feature] Contact Form [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended labels Sep 28, 2017
@jeherve jeherve added this to the 5.4 milestone Sep 28, 2017
@rclations rclations mentioned this issue Sep 28, 2017
Merged
@jeherve jeherve removed this from the 5.4 milestone Oct 3, 2017
@rclations
Copy link
Contributor

@jeherve Since all validation was removed in #7890, is this something that should still be added?

@jeherve
Copy link
Member Author

jeherve commented Oct 11, 2017

Good point.

I think I'll edit the original description, because I think it would be valuable to have date validation in the future.

@jeherve jeherve changed the title Contact Form / Date Picker: missing date validation in FF and Safari Contact Form / Date Picker: add date validation in all browsers Oct 11, 2017
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Good For Community and removed [Type] Bug When a feature is broken and / or not performing as intended labels Oct 11, 2017
@stale
Copy link

stale bot commented Sep 18, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Sep 18, 2018
@jeherve jeherve mentioned this issue Aug 12, 2020
Closed
@jeherve
Copy link
Member Author

jeherve commented Aug 12, 2020

This was also brought up in #16815. cc @MuhammedSwalihct

Now that a few years have passed, it may be worth reconsidering using the date input type we had removed in #7890. Browser support may have improved over the years.

@stale stale bot removed the [Status] Stale label Aug 12, 2020
@jeherve jeherve mentioned this issue Oct 12, 2020
Open
@jeherve jeherve mentioned this issue Feb 17, 2021
Open
This was referenced Jul 23, 2024
Closed
Open
@jeherve
Copy link
Member Author

jeherve commented Jul 23, 2024

Related: #11251

@simison simison changed the title Contact Form / Date Picker: add date validation in all browsers Forms: add date validation to date picker field in all browsers Jan 15, 2025
@enejb enejb linked a pull request Feb 10, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enejb enejb

Labels
[Feature] Contact Form Good For Community [Pri] Low [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forms: add date validation in all browsers Automattic/jetpack
3 participants
@enejb @jeherve @rclations