-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Fix Account Protection initial toggle state on activation #41699
base: add/account-protection
Are you sure you want to change the base?
Protect: Fix Account Protection initial toggle state on activation #41699
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Protect plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
…tion-toggle-initial-state
…tion-toggle-initial-state
Fixes #
When first activating Protect, the Account Protection toggle shows as off even though the module has since been activated. A page refresh confirm this, but we need to ensure we always have the correct status on Settings page load.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: