Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost: Introduce base minify class for JS and CSS modules #41716

Draft
wants to merge 6 commits into
base: update/boost/unschedule_404_tester_cron
Choose a base branch
from
Draft

Boost: Introduce base minify class for JS and CSS modules #41716

wants to merge 6 commits into from
+120 −31

Conversation

dilirity
Copy link
Member

Fixes #

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@donnchawp
Schedule the daily jobs from the setup, rather than activation
7530633 
If the plugin is deactivated with the concatenation modules enabled
then the activate function isn't called when the plugin is activated
again.
The setup function runs on every pageload, but it does an is_admin()
check to reduce DB queries.
@donnchawp
Revert changes to setup function
32dd4b7
@donnchawp
Use base Minify class for both modules
6720453
@donnchawp
This code doesn't belong here
c2eb284
@donnchawp
Revert previous changes and rename Minify php file
1204a3f
@donnchawp
Track how many minify modules are active in Minify
ec6897d
@dilirity dilirity changed the base branch from trunk to update/boost/unschedule_404_tester_cron February 11, 2025 12:33
@github-actions github-actions bot added [Boost Feature] Minify [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress labels Feb 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/boost

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 11, 2025
@dilirity dilirity mentioned this pull request Feb 11, 2025
Open
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/lib/minify/functions-helpers.php 0/141 (0.00%) 0.00% 10 💔

1 file is newly checked for coverage.

File Coverage
projects/plugins/boost/app/modules/optimizations/minify/Minify.php 0/18 (0.00%) 💔

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@donnchawp donnchawp

Labels
[Boost Feature] Minify [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilirity @donnchawp