-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Protection: Improve auth success flow #41727
base: add/packages/account-protection-password-detection-error-notices
Are you sure you want to change the base?
Account Protection: Improve auth success flow #41727
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
…r-notices' into improve/packages/account-protection-auth-success-flow
Fixes #
Currently once a valid auth code is submitted in the password detection flow, we immediately redirect to
/wp-admin
. This PR improves the flow by rendering a success notice and updated content with direction to either proceed to your dashboard or proceed to update your password in your profile.Additionally, this PR adds a success notice for the resend email action.
Note: Based off of - #41692
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Proceed without updating
andCreate a new password
and ensure that you are redirected appropriatelyScreen captures
Auth success:
![Screen Capture on 2025-02-11 at 09-18-29](https://private-user-images.githubusercontent.com/43220201/412115800-80627bef-9f6c-43c4-90eb-e7e656575e69.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDEzMTgsIm5iZiI6MTczOTM0MTAxOCwicGF0aCI6Ii80MzIyMDIwMS80MTIxMTU4MDAtODA2MjdiZWYtOWY2Yy00M2M0LTkwZWItZTdlNjU2NTc1ZTY5LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA2MTY1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM0ZTU2OTU5OTUxMTA2NGI0NjNmMGViZjcxMmQ3Nzg4YjllMTY5MDJhYjE0OWM3ZDViZTM5MGUzZTMzY2MzYjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.i0h-hU5s9HoRNbOq5RkwDUfztJMqWyX4xcXvPeiyat8)
Resend success:
![Screen Capture on 2025-02-11 at 09-19-13](https://private-user-images.githubusercontent.com/43220201/412115926-3c8dc12f-505f-4425-b375-07ac10feb64b.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNDEzMTgsIm5iZiI6MTczOTM0MTAxOCwicGF0aCI6Ii80MzIyMDIwMS80MTIxMTU5MjYtM2M4ZGMxMmYtNTA1Zi00NDI1LWIzNzUtMDdhYzEwZmViNjRiLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA2MTY1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMxYTE1NzJlZmRmMzY1YTAyMjA4MmZhMjIxOTdlOTM3NzcwNzJmYWI0NzY4NmE4YTMyMmJmYzkxMWU4MWM3NDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.0MH0WQkF_RCbG0DwnXoNKuqS_MOcYaURxmy7nb7xUCY)