Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ia): endpoint updates #1974

Merged
merged 6 commits into from
Feb 10, 2025
Merged

fix(ia): endpoint updates #1974

merged 6 commits into from
Feb 10, 2025

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Nov 26, 2024

All Submissions:

Changes proposed in this Pull Request:

Update Donate Block API endpoints from Automattic/newspack-plugin#3564

Instructions at Automattic/newspack-plugin#3564

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost missed this one! I think it still needs some slight adjustments, see below.

src/blocks/donate/edit/index.tsx Outdated Show resolved Hide resolved
src/blocks/donate/edit/index.tsx Outdated Show resolved Hide resolved
@miguelpeixe
Copy link
Member Author

Thanks for catching those, @dkoo!

@miguelpeixe miguelpeixe requested a review from dkoo February 10, 2025 18:49
@miguelpeixe miguelpeixe merged commit 925b022 into epic/ia Feb 10, 2025
8 checks passed
@miguelpeixe miguelpeixe deleted the fix/ia-endpoint-updates branch February 10, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants