Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ia): clean up health check wizard #3721

Open
wants to merge 2 commits into
base: epic/ia
Choose a base branch
from

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

The Health Check wizard has been deprecated.

How to test the changes in this Pull Request:

There shouldn't be any functional change, as the Health Check wizard is already invisible in the new UI. Navigate the "Newspack -> Dashboard" and "Newspack -> Settings" pages and tabs and confirm there are no errors.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 4, 2025
@miguelpeixe miguelpeixe self-assigned this Feb 4, 2025
@miguelpeixe miguelpeixe requested a review from a team as a code owner February 4, 2025 18:02
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems that I can see! Maybe we should amend the docblock for this method too? These are plugins that have been tested with our platform in production, but for which we don't provide any direct support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Information Architecture [Status] Needs Review The issue or pull request needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants