Skip to content

Commit

Permalink
Manually check BUILDKITE_TAG in Makefile
Browse files Browse the repository at this point in the history
  • Loading branch information
mokagio committed Jun 13, 2024
1 parent f6d2da0 commit 6905df1
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,16 @@ DEV_SERVER ?= false

# electron-builder publish option
# options: always|onTag|onTagOrDraft|never
PUBLISH ?= onTag

#
# Unfortunately, electron-builder does not recognize Buildkite as a provider, so we need to manually check that.
# See https://github.com/electron-userland/electron-builder/blob/14942b70a5da79a5e36e330f64de66ec501b4ac6/packages/electron-publish/src/publisher.ts#L139
#
# Notice the use of ?= to still be able to override at call time
ifeq ($(strip $(BUILDKITE_TAG)),)
PUBLISH ?= never
else
PUBLISH ?= always
endif

# Main targets
.PHONY: start
Expand Down

0 comments on commit 6905df1

Please sign in to comment.