Lint Fixes (#1782)

* Lint Fixes

* Fix more lint issues

after_sign_hook.js

@@ -9,7 +9,7 @@ module.exports = async function(params) {
   }
 
   if (!process.env.CIRCLE_TAG || process.env.CIRCLE_TAG.length === 0) {
-    console.log('Not on a tag. Skipping notarization');
+    console.log('Not on a tag. Skipping notarization'); // eslint-disable-line no-console
     return;
   }
 
@@ -27,7 +27,7 @@ module.exports = async function(params) {
     throw new Error(`Cannot find application at: ${appPath}`);
   }
 
-  console.log(`Notarizing ${appId} found at ${appPath}`);
+  console.log(`Notarizing ${appId} found at ${appPath}`); // eslint-disable-line no-console
 
   try {
     await electron_notarize.notarize({
@@ -38,8 +38,8 @@ module.exports = async function(params) {
       ascProvider: 'AutomatticInc',
     });
   } catch (error) {
-    console.error(error);
+    console.error(error); // eslint-disable-line no-console
   }
 
-  console.log(`Done notarizing ${appId}`);
+  console.log(`Done notarizing ${appId}`); // eslint-disable-line no-console
 };

desktop/index.js

@@ -1 +1 @@
-var app = require('./app')();
+require('./app')();

desktop/updater/lib/Updater.js

@@ -21,7 +21,7 @@ class Updater extends EventEmitter {
   ping() {}
 
   onDownloaded(event) {
-    console.log('Update downloaded');
+    console.log('Update downloaded'); // eslint-disable-line no-console
 
     // electron-updater provides us with new version
     if (event.version) {
@@ -32,11 +32,11 @@ class Updater extends EventEmitter {
   }
 
   onNotAvailable() {
-    console.log('Update is not available');
+    console.log('Update is not available'); // eslint-disable-line no-console
   }
 
   onError(event) {
-    console.log('Update error', event);
+    console.log('Update error', event); // eslint-disable-line no-console
   }
 
   onConfirm() {}
@@ -94,7 +94,7 @@ class Updater extends EventEmitter {
     let text = originalText;
 
     for (const key in macros) {
-      if (macros.hasOwnProperty(key)) {
+      if (Object.prototype.hasOwnProperty.call(macros, key)) {
         text = text.replace(new RegExp(`{${key}}`, 'ig'), macros[key]);
       }
     }

desktop/updater/manual-updater/index.js

@@ -41,7 +41,7 @@ class ManualUpdater extends Updater {
 
       if (releaseResp.status !== 200) {
         this.emit('error');
-        console.log(releaseResp);
+        console.log(releaseResp); // eslint-disable-line no-console
         return;
       }
 
@@ -58,14 +58,15 @@ class ManualUpdater extends Updater {
 
         if (configResp.status !== 200) {
           this.emit('error');
-          console.log(configResp);
+          console.log(configResp); // eslint-disable-line no-console
           return;
         }
 
         const configBody = await configResp.text();
         const releaseConfig = yaml.safeLoad(configBody);
 
         if (semver.lt(app.getVersion(), releaseConfig.version)) {
+          // eslint-disable-next-line no-console
           console.log(
             'New update is available, prompting user to update to',
             releaseConfig.version
@@ -79,7 +80,7 @@ class ManualUpdater extends Updater {
       }
     } catch (err) {
       this.emit('error');
-      console.log(err.message);
+      console.log(err.message); // eslint-disable-line no-console
     }
   }
 

get-config.js

@@ -18,6 +18,7 @@ function readConfig() {
     }
     return config;
   } catch (e) {
+    // eslint-disable-next-line no-console
     console.error(
       'Could not read in the required configuration file.\n' +
         'This file should exist as `config.json` inside the project root directory.\n' +

lib/components/boot-warning/index.jsx

@@ -1,9 +1,14 @@
 import React from 'react';
+import PropTypes from 'prop-types';
 
 import './style';
 
 const BootWarning = ({ children }) => (
   <h3 className="boot-warning__message">{children}</h3>
 );
 
+BootWarning.propTypes = {
+  children: PropTypes.node.isRequired,
+};
+
 export default BootWarning;

lib/components/clipboard-button/index.jsx

@@ -1,6 +1,5 @@
 import React, { useEffect, useRef, useState } from 'react';
 import PropTypes from 'prop-types';
-import ReactDom from 'react-dom';
 import Clipboard from 'clipboard';
 
 function ClipboardButton({ text }) {

lib/context-menu.jsx

@@ -78,6 +78,12 @@ export class ContextMenu extends Component {
   }
 }
 
+ContextMenu.propTypes = {
+  children: PropTypes.node.isRequired,
+  currentWindow: PropTypes.object.isRequired,
+  Menu: PropTypes.object.isRequired,
+};
+
 export const MenuItem = () => null;
 MenuItem.displayName = 'MenuItem';
 

lib/controls/checkbox/index.jsx

@@ -1,7 +1,8 @@
 import React from 'react';
 import classNames from 'classnames';
+import PropTypes from 'prop-types';
 
-export default function CheckboxControl({ className, ...props }) {
+function CheckboxControl({ className, ...props }) {
   return (
     <span className={classNames('checkbox-control', className)}>
       <input type="checkbox" {...props} />
@@ -11,3 +12,9 @@ export default function CheckboxControl({ className, ...props }) {
     </span>
   );
 }
+
+CheckboxControl.propTypes = {
+  className: PropTypes.string.isRequired,
+};
+
+export default CheckboxControl;

lib/controls/toggle/index.jsx

@@ -1,7 +1,8 @@
 import React from 'react';
 import classNames from 'classnames';
+import PropTypes from 'prop-types';
 
-export default function ToggleControl({ className, ...props }) {
+function ToggleControl({ className, ...props }) {
   return (
     <span className={classNames('toggle-control', className)}>
       <input type="checkbox" {...props} />
@@ -13,3 +14,9 @@ export default function ToggleControl({ className, ...props }) {
     </span>
   );
 }
+
+ToggleControl.propTypes = {
+  className: PropTypes.string,
+};
+
+export default ToggleControl;

lib/dialogs/import/source-importer/executor/index.jsx

@@ -85,7 +85,6 @@ class ImportExecutor extends React.Component {
           }, 200);
           break;
         default:
-          console.log(`Unrecognized status event type "${type}"`);
       }
     });
     return thisImporter;

lib/dialogs/import/source-importer/utils/test-importer.js

@@ -7,11 +7,11 @@ import { EventEmitter } from 'events';
 class TestImporter extends EventEmitter {
   constructor(arg) {
     super();
-    console.log(arg);
+    console.log(arg); // eslint-disable-line no-console
   }
 
   importNotes(files) {
-    console.log(files);
+    console.log(files); // eslint-disable-line no-console
 
     let count = 0;
     const counter = window.setInterval(() => {

lib/dialogs/radio-settings-group.jsx

@@ -1,4 +1,5 @@
 import React from 'react';
+import PropTypes from 'prop-types';
 
 import CheckboxControl from '../controls/checkbox';
 
@@ -13,4 +14,11 @@ const RadioGroup = ({ groupSlug, slug, isEnabled, onChange }) => (
   />
 );
 
+RadioGroup.propTypes = {
+  groupSlug: PropTypes.string,
+  slug: PropTypes.string,
+  isEnabled: PropTypes.bool.isRequired,
+  onChange: PropTypes.func.isRequired,
+};
+
 export default RadioGroup;

lib/dialogs/settings-group.jsx

@@ -64,8 +64,14 @@ export const SettingsGroup = ({
 };
 
 SettingsGroup.propTypes = {
+  activeSlug: PropTypes.string,
+  children: PropTypes.node,
   description: PropTypes.string,
   learnMoreURL: PropTypes.string,
+  onChange: PropTypes.func,
+  renderer: PropTypes.func,
+  slug: PropTypes.string,
+  title: PropTypes.string,
 };
 
 export default SettingsGroup;

lib/dialogs/settings/panels/account.jsx

@@ -1,12 +1,9 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-
 import PanelTitle from '../../../components/panel-title';
 import SettingsGroup, { Item } from '../../settings-group';
 import ToggleGroup from '../../toggle-settings-group';
 import TopRightArrowIcon from '../../../icons/arrow-top-right';
-
-import getConfig from '../../../../get-config';
 import { viewExternalUrl } from '../../../utils/url-utils';
 
 const AccountPanel = props => {

lib/dialogs/toggle-settings-group.jsx

@@ -1,4 +1,5 @@
 import React from 'react';
+import PropTypes from 'prop-types';
 
 import ToggleControl from '../controls/toggle';
 
@@ -12,4 +13,11 @@ const ToggleGroup = ({ groupSlug, slug, isEnabled, onChange }) => (
   />
 );
 
+ToggleGroup.propTypes = {
+  groupSlug: PropTypes.string,
+  slug: PropTypes.string,
+  isEnabled: PropTypes.bool.isRequired,
+  onChange: PropTypes.func.isRequired,
+};
+
 export default ToggleGroup;

lib/editable-list/index.jsx

@@ -9,6 +9,7 @@ export class EditableList extends Component {
   static displayName = 'EditableList';
 
   static propTypes = {
+    className: PropTypes.string,
     editing: PropTypes.bool.isRequired,
     items: PropTypes.array.isRequired,
     renderItem: PropTypes.func.isRequired,

lib/editor/css-class-wrapper.jsx

@@ -6,6 +6,7 @@ export const CssClassWrapper = ({ children, className }) => (
 );
 
 CssClassWrapper.propTypes = {
+  children: PropTypes.node.isRequired,
   className: PropTypes.string.isRequired,
 };
 

lib/note-content-editor.jsx

@@ -33,6 +33,7 @@ export default class NoteContentEditor extends Component {
     content: PropTypes.shape({
       text: PropTypes.string.isRequired,
       hasRemoteUpdate: PropTypes.bool.isRequired,
+      version: PropTypes.string,
     }),
     filter: PropTypes.string.isRequired,
     noteId: PropTypes.string,

lib/note-detail/index.jsx

@@ -2,8 +2,6 @@ import React, { Component } from 'react';
 import PropTypes from 'prop-types';
 import { connect } from 'react-redux';
 import { get, debounce, noop } from 'lodash';
-import classNames from 'classnames';
-
 import analytics from '../analytics';
 import appState from '../flux/app-state';
 import { viewExternalUrl } from '../utils/url-utils';

lib/note-detail/render-to-node.js

@@ -13,7 +13,7 @@ export const renderToNode = (node, content) => {
           .then(({ default: highlight }) => {
             codeElements.forEach(highlight.highlightBlock);
           })
-          .catch(console.log);
+          .catch();
       }
     });
 };

lib/note-info/index.jsx

@@ -13,6 +13,8 @@ import filterNotes from '../utils/filter-notes';
 
 export class NoteInfo extends Component {
   static propTypes = {
+    isMarkdown: PropTypes.bool.isRequired,
+    isPinned: PropTypes.bool.isRequired,
     note: PropTypes.object,
     markdownEnabled: PropTypes.bool,
     onPinNote: PropTypes.func.isRequired,

lib/note-list/index.jsx

@@ -576,4 +576,11 @@ const mapDispatchToProps = (dispatch, { noteBucket }) => ({
   onPinNote: (note, pin) => dispatch(pinNote({ noteBucket, note, pin })),
 });
 
+NoteList.propTypes = {
+  hasLoaded: PropTypes.bool.isRequired,
+  nextNote: PropTypes.object,
+  prevNote: PropTypes.object,
+  selectedNoteContent: PropTypes.string,
+};
+
 export default connect(mapStateToProps, mapDispatchToProps)(NoteList);

lib/search-bar/index.jsx

@@ -3,6 +3,7 @@
  */
 import React from 'react';
 import { connect } from 'react-redux';
+import PropTypes from 'prop-types';
 
 /**
  * Internal dependencies
@@ -53,4 +54,11 @@ const mapDispatchToProps = (dispatch, { noteBucket, onNoteOpened }) => ({
 
 SearchBar.displayName = 'SearchBar';
 
+SearchBar.propTypes = {
+  onNewNote: PropTypes.func.isRequired,
+  onToggleNavigation: PropTypes.func.isRequired,
+  query: PropTypes.string,
+  showTrash: PropTypes.bool.isRequired,
+};
+
 export default connect(mapStateToProps, mapDispatchToProps)(SearchBar);

lib/search-field/index.jsx

@@ -15,6 +15,7 @@ export class SearchField extends Component {
   static displayName = 'SearchField';
 
   static propTypes = {
+    filter: PropTypes.string,
     isTagSelected: PropTypes.bool.isRequired,
     placeholder: PropTypes.string.isRequired,
     searchFocus: PropTypes.bool.isRequired,

lib/state/domain/notes.js

@@ -1,5 +1,4 @@
 import { noteBucket } from './buckets';
-import appState from '../../flux/app-state';
 import isEmailTag from '../../utils/is-email-tag';
 import { createTag } from './tags';
 

lib/state/domain/tags.js

@@ -49,7 +49,9 @@ export const renameTag = ({ tag, name: newName }) => (dispatch, getState) => {
       ...note,
       data: {
         ...note.data,
-        tags: note.data.tags.map(tag => (tag === tagName ? name : tag)),
+        tags: note.data.tags.map(noteTag =>
+          noteTag === tagName ? name : noteTag
+        ),
       },
     }))
     .forEach(note => noteBucket().update(note.id, note.data));
@@ -65,7 +67,7 @@ export const trashTag = ({ tag }) => (dispatch, getState) => {
       ...note,
       data: {
         ...note.data,
-        tags: note.data.tags.filter(tag => tag !== tagName),
+        tags: note.data.tags.filter(noteTag => noteTag !== tagName),
       },
     }))
     .forEach(note => noteBucket().update(note.id, note.data));

lib/tag-suggestions/index.jsx

@@ -12,6 +12,7 @@ export class TagSuggestions extends Component {
 
   static propTypes = {
     filteredTags: PropTypes.array.isRequired,
+    onSearch: PropTypes.func.isRequired,
     query: PropTypes.string.isRequired,
   };