Integrate Account Management component into the Settings Page #10287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +6.08 kB (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
mordeth
changed the title
mordeth
changed the base branch from
develop
to
update/10256-extract-account-settings-logic
Base automatically changed from
update/10256-extract-account-settings-logic
to
develop
February 10, 2025 12:41
oaratovskyi
approved these changes
Feb 11, 2025
|
Great job @mordeth, I’ve also done a review myself and the embedded account management component within WooPayments settings looks and works as expected. |
|
I’ll add a few comments here, as I had a chance to QA this as well. Like @orcungogus said above, everything works great and as expected! My comments below are purely visual tweaks, so feel free to disregard them if something isn’t possible to fix.
also, the body copy to match the other sections settings?
WDYT @orcungogus ? Besides all of that I think this Account management is a great addition and (a note for the future) a great candidate to have its own section :) BTW.
Thanks for setting this up on jurassic.ninja – what a great way to share the testing site! |
|
@rogermattic I’ll try to update the styling in a follow-up PR. Just a heads-up, these settings are provided by Stripe within an iframe, so our configuration options are limited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9129
Changes proposed in this Pull Request
This PR introduces the Account Management component to the WooPayments settings page, allowing merchants to update their business details directly within WooCommerce. This enhancement eliminates the need to navigate to the Stripe Express dashboard, providing a more seamless and user-friendly experience.
Testing instructions
add/9129-account-management-componentbranch.address_line1_no_matchin Address line 1 and1111as last 4 digits of the SSN (to trigger certain verification conditions). You must pass in legitimate values for thecity,state, andpostal_codearguments. Leave phone number empty.111111111in the SSN to trigger identity mismatch.110000000and000999999992to trigger another verification.After being redirected to the Overview page, go to Payments > Settings. Scroll down to the Account Details section and confirm that a loader appears before the account management component is fully displayed.
Verify the Account Management component is displayed successfully.
Testing progressive onboarding
*Reset the account created in the previous steps.
Note: This may not be possible on a JN site if all slots are occupied.
Enter your details and click Continue.
On the next screen, review the information and select Agree and Submit.
After being redirected to the Overview page, go to Payments > Settings. Scroll down to the Account Details section and confirm that a loader appears before the account management component is fully displayed.
Verify the Account Management component is displayed successfully.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge