Add Stripe embedded account notifications component on the Overview page #10314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +716 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
oaratovskyi
changed the title
added 2 commits
February 7, 2025 13:13
…ent has failed to load.
Base automatically changed from
update/10256-extract-account-settings-logic
to
develop
February 10, 2025 12:41
mordeth
approved these changes
Feb 11, 2025
| .stripe-notifications-banner-wrapper { | ||
| padding-bottom: 0.25rem; // Stripe does it in their furever.dev site too so the border is visible. | ||
| overflow: hidden; // Stripe does it in their furever.dev site too so the border is visible. | ||
| margin-bottom: 24px; |
There was a problem hiding this comment.
Minor suggestion.
Suggested change
| margin-bottom: 24px; | |
| margin-bottom: $gap-large; |
|
@oaratovskyi I was just looking at this. First of all – great work, it's looking great:) I was just wondering if we have any control over where the badges are rendered. I noticed that this is the only instance (?). where the page prefixes the text label: Could we possibly move it so it follows the label? Do you think we should @orcungogus ? |
|
I completely agree but I don’t think we have control over that @rogermattic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9128
Changes proposed in this Pull Request
This pull request introduces an enhancement to the WooCommerce Payments plugin by integrating Stripe's notification banner component directly into the Payments > Overview page. This integration ensures that merchants receive timely Know Your Customer (KYC) notifications within WooPayments, eliminating the need to navigate to the Stripe Express dashboard. By providing these notifications in-plugin, merchants can promptly address account verification requirements, thereby reducing potential delays in account activation and improving the overall user experience.
When we fail to load the embedded component, we'll show the old po and update business details task.
Known issues / questions:
A little bit below there's a video section where you can look at it in action.
Images
Video
KnpYfS.mov
Testing instructions
add/9128-account-notifs-component-on-overview-pageon clientMore than 100Mannual revenue in the MOX and other params as you preferaddress_line1_no_matchin Address line 1 and1111as last 4 digits of the SSN (to trigger certain verification conditions). You must pass in legitimate values for thecity,state, andpostal_codearguments. Leave phone number empty.111111111in the SSN to trigger identity mismatch.110000000and000999999992to trigger another verification.Testing progressive onboarding
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge