Improve CSV download experience for Payouts #10346
Open
+80
−200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +74 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
# Conflicts: # includes/wc-payment-api/class-wc-payments-api-client.php
shendy-a8c
changed the title
shendy-a8c
requested review from
nagpai and
a team
and removed request for
nagpai
|
The commit message of 4335529:
should be
|
|
This PR is ready for review. @jessy-p did a lot of the work. What I added:
|
6 tasks
Manual test🏆 ✅ - The PR tests well with multi-page as well as a single page export of payouts. ✅ - In each of the tests, the exported CSV showed correct data |
nagpai
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
I did a code review after doing reviews for the dispute exports PR.
The changes here are similar to the dispute exports PR, but for payouts. The PR has taken into account some recent minor changes to the appearance and wording of the export notice. The PR also uses payout instead of deposit for any newly added code, while taking care not to cause any regression by changing any existing names.
The PR tests well, I have a separate comment with the details. This is ready to 🚢 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/transact-platform-server/issues/7187
Changes proposed in this Pull Request
Testing instructions
Test this PR with https://github.com/Automattic/transact-platform-server/pull/7206
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge