-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E2E documentation for Playwright #10354
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the README are looking very good! I left a comment about the "running tests in group" section since I'm not being able to get the env variables set only by running the commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are looking good. Thanks for updating the E2E documentation! Let's 🚢 it!
Hi @allie500, @eduardoumpierre! While reviewing this PR, I missed that we still define the @woocommerce/e2e-environment and @woocommerce/e2e-utils packages as a devDependency in our Can we safely remove them? |
Btw thanks for adding that FAQ, @allie500! That's a great idea. |
Hey @alopezari! We left the |
Thanks @eduardoumpierre! Nothing pending from my side then in this PR, I shared my thoughts on the |
Thanks, @alopezari. I copied it over from the old Playwright ( |
Fixes #10334
Changes proposed in this Pull Request
This PR updates the E2E documentation to reflect our recently completed migration from Puppeteer to Playwright. It also removes the Readme file that was located in
tests/e2e-pw
. This is a documentation update only so there are no tests included in this PR.Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge