Add metadata to New Follower E-Mail #1172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
akirk
force-pushed
the
enrich-follower-email
branch
from
ca9c4c3 to
49bec73
Compare
akirk
requested review from
pfefferle and
obenland
and removed request for
pfefferle
obenland
requested changes
Feb 4, 2025
| $message .= \esc_url( \admin_url( $admin_url ) ) . "\r\n\r\n"; | ||
|
|
||
| \wp_mail( $email, $subject, $message ); | ||
| $subject = \sprintf( \__( '[%1$s] Follower: %2$s', 'activitypub' ), get_option( 'blogname' ), $actor['name'] ); |
There was a problem hiding this comment.
Could we call this "New Follower:"?
|
|
||
| $alt_function = function ( $mailer ) use ( $actor, $admin_url ) { | ||
| /* translators: 1: Blog name, 2: Follower name */ | ||
| $message = \sprintf( \__( 'New Follower: %2$s.', 'activitypub' ), \get_option( 'blogname' ), $actor['name'] ) . "\r\n\r\n"; |
There was a problem hiding this comment.
If we don't expect to use the blog name, let's just limit it to one placeholder?
Comment on lines
+9
to
+10
| $actor = array(); | ||
| return; |
There was a problem hiding this comment.
Could you help me understand why $actor gets set to an empty array before returning? Does it has to do with how it's being used in new_follower() later on?
| </a> | ||
| </td> | ||
| <td> | ||
|
|
Comment on lines
+36
to
+38
| if ( ! empty( $actor['summary'] ) ) { | ||
| echo wp_kses_post( nl2br( $actor['summary'] ) ); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if ( ! empty( $actor['summary'] ) ) { | |
| echo wp_kses_post( nl2br( $actor['summary'] ) ); | |
| } | |
| if ( ! empty( $actor['summary'] ) ) : | |
| echo wp_kses_post( nl2br( $actor['summary'] ) ); | |
| endif; |
| <?php | ||
|
|
||
| /** | ||
| * Fires at the bottom of the new follower email. |
There was a problem hiding this comment.
Suggested change
| * Fires at the bottom of the new follower email. | |
| * Fires at the bottom of the new follower email. | |
| * | |
| * @param array $actor The actor that followed the blog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some metadata like the user icon and the user summary to the new follower e-mail and adds an action for other plugins to include their data (for example, a Follow Back link). See akirk/friends#428