Bump Min WP Version to 6.4 #1287
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfefferle
reviewed
Feb 7, 2025
| } | ||
|
|
||
| if ( | ||
| ! \function_exists( 'register_block_type_from_metadata' ) || |
There was a problem hiding this comment.
let's keep that, so that it will still work with classicpress or the classic editor enabled.
There was a problem hiding this comment.
The functions exist with the classic editor enabled. Should ClassicPress be a consideration?
pfefferle
reviewed
Feb 7, 2025
| * | ||
| * @return array The attachment IDs. | ||
| */ | ||
| protected function get_classic_editor_image_attachments( $max_images ) { |
There was a problem hiding this comment.
let's keep that, for people that still use the classic editor
There was a problem hiding this comment.
Ah, this is only about the attachments 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's bump the min version to 6.4. The last three versions is what the Plugin Directory expects plugins to be tested with and it gets us guaranteed
WP_HTML_Tag_Processorsupport. 6.4 is also the first version that supports PHP 8.3.Based on https://fedi.wrm.sr/software/wordpress/versions, 126 installs are below 6.4, or around 1.47% of all ActivityPub installs.
Proposed changes:
Other information: