Speed up nightly job by running in a different agent #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazytonyli
force-pushed
the
change-nightly-job-agent
branch
from
c140587 to
d27a38a
Compare
oguzkocer
reviewed
Jan 14, 2025
There was a problem hiding this comment.
I don't think we care how long this job takes as it's never a blocker. So, it makes sense to focus on the cost and availability. Since I am not sure how busy the tumblr-metal agent is and what the cost looks like, I'll leave this decision to @jkmassel.
|
@crazytonyli Since #530 significantly sped up the tests, do you think this PR is still relevant? I don't have a strong opinion on it either way, just wanted to check in with you to avoid the PR going stale. |
|
Nope. We don't need to change the agent now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.