Follow button - make 'Unsubscribe' the default followed copy.

[Addison-Stavlo]

Related to # #98915

Proposed Changes

• Updates the feed stream header follow button to use "Unsubscribe" as the custom label.
• Removes a couple redundant uses of followLabel props, since they are passing the same string as the default.

BEFORE

AFTER

Why are these changes being made?

• Noted on Reader Feed: a "Subscribed" button unsubscribes me without warning #98915

Testing Instructions

• Go to the reader. The following places are also shown in the Before/After screenshots above.
• Go to the feed for an individual blog, verify the follow button in the headers followed state says "Unsubscribe"
• Verify the post card ellipsis menus and discover v2 cards still have the same "Subscribe" label when unsubscribed.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-133747

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-133747&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-133747&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~9 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
write-flow                             -54 B  (-0.0%)       -9 B  (-0.0%)
reader                                 -54 B  (-0.0%)       -9 B  (-0.0%)
plugins                                -54 B  (-0.0%)       -9 B  (-0.0%)
link-in-bio-tld-flow                   -54 B  (-0.0%)       -9 B  (-0.0%)
jetpack-cloud-plugin-management        -54 B  (-0.0%)       -9 B  (-0.0%)
home                                   -54 B  (-0.0%)       -9 B  (-0.0%)
build-flow                             -54 B  (-0.0%)       -9 B  (-0.0%)
a8c-for-agencies-plugins               -54 B  (-0.0%)       -9 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~4 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-design-blocks                                   -54 B  (-0.0%)       -9 B  (-0.0%)
async-load-calypso-components-web-preview-component        -54 B  (-0.0%)       -9 B  (-0.0%)
async-load-calypso-reader-site-stream                      +32 B  (+0.2%)      +13 B  (+0.2%)
async-load-calypso-reader-feed-stream                      +32 B  (+0.2%)      +13 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[holdercp]

I didn't find any regressions and the toggle is updated:

One question though: I noticed the issue suggested changing the icon to "lineSolid". Was there a reason to keep the icon as is?

[Addison-Stavlo]

One question though: I noticed #98915 (comment) suggested changing the icon to "lineSolid". Was there a reason to keep the icon as is?

Ah nice catch, thank you. That will make a bit more sense here i think. I will update this to use that.

[Addison-Stavlo]

Im pausing to discuss on the issue: #98915 (comment)

There are a handful of already implemented "Unsubscribe" that don't use the lineSolid icon. And Im really not sure that we would want to update all of these to be - Unsubscribe.

[Addison-Stavlo]

This has been simplified from its original form. I have updated the PR description and testing instructions.

We are only changing the one button, and removing a couple of the same redundant props we already tested. I will ship this once checks are good.