Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Add Referrers module to Realtime tab #99991

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

a8ck3n
Copy link
Contributor

@a8ck3n a8ck3n commented Feb 19, 2025

Follows: #99940

Proposed Changes

Adds the Referrers module to the Realtime tab.

SCR-20250219-tpkq

Note: Children of the Search Engines entry are not processed at the moment so the full values are shown. This complicates the data a bit so I think we can iterate on this point in a follow-up.

Why are these changes being made?

To match designs per internal P2 post.

Testing Instructions

  • Visit the Traffic → Realtime tab.
  • Confirm the Referrers module is displayed with an initial loading state.
  • Confirm the views update as new data comes in.

If you see large numbers appear suddenly in the main Views column, please report it!

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@a8ck3n a8ck3n self-assigned this Feb 19, 2025
@a8ck3n a8ck3n requested a review from a team February 19, 2025 13:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 19, 2025
@a8ck3n a8ck3n added the [Feature] Stats Everything related to our analytics product at /stats/ label Feb 19, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 19, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +229 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~18 bytes added 📈 [gzipped])

name                                              parsed_size           gzip_size
async-load-calypso-my-sites-stats-pages-realtime       +172 B  (+1.5%)      +18 B  (+0.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Feb 19, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-real-time-referrers on your sandbox.

Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to ship and iterate 👍

@kangzj
Copy link
Contributor

kangzj commented Feb 20, 2025

Maybe we could just remove all the children in Search Engine item and ship?

@a8ck3n
Copy link
Contributor Author

a8ck3n commented Feb 20, 2025

Maybe we could just remove all the children in Search Engine item and ship?

Ha, ha. I was actually thinking the same thing, at least initially. I'll add that with a TODO and we can think on how best to handle it before spending too much time on it.

@a8ck3n a8ck3n marked this pull request as ready for review February 20, 2025 02:50
@a8ck3n a8ck3n merged commit a010925 into trunk Feb 20, 2025
13 checks passed
@a8ck3n a8ck3n deleted the update/stats-real-time-referrers branch February 20, 2025 03:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants