-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Add Referrers module to Realtime tab #99991
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~6 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~18 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to ship and iterate 👍
Maybe we could just remove all the children in Search Engine item and ship? |
Ha, ha. I was actually thinking the same thing, at least initially. I'll add that with a TODO and we can think on how best to handle it before spending too much time on it. |
Follows: #99940
Proposed Changes
Adds the Referrers module to the Realtime tab.
Note: Children of the Search Engines entry are not processed at the moment so the full values are shown. This complicates the data a bit so I think we can iterate on this point in a follow-up.
Why are these changes being made?
To match designs per internal P2 post.
Testing Instructions
If you see large numbers appear suddenly in the main Views column, please report it!
Pre-merge Checklist