-
Notifications
You must be signed in to change notification settings - Fork 46
Support React 16.9 #46
base: master
Are you sure you want to change the base?
Conversation
Deploy preview for react-block-ui ready! Built with commit 1ba65ef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be a breaking change because we are requiring the user be on react version 16. IIRC, v14, and v15 don't have that renamed method unless they backwards patched it. If that is the case then its safe.
Regardless, one of the tests is now failing as a result of renaming the lifecycle methods, you may want to check that out
Yes, this doesn't add support for 16.9 as much as it drops support for for older versions of react (which are still listed in the package.json). |
Hm... You are right, I haven't mentioned that it would break in React 15. |
Also, react still warns about using |
If my vote matters I'd say use new lifecycle methods instead of hooks, React 16.8 could cut many people off... Since it's what, 1 year old? |
No, not 13 and 14... but mostly 15 and [early versions of] 16 since they don't have UNSAFE_ to lifecycle methods. But not even that really. This PR's is incomplete since it doesn't bump the version and even then it would still produce warnings in strict mode. A better solution would be to replace the unsafe lifecycle with the new methods. |
Prepend UNSAFE_ to lifecycle methods