New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove using namespace from global scope of header files #93

Merged

killenheladagen merged 1 commit into main from rm-using-ns

Sep 9, 2024

Contributor

killenheladagen commented Aug 30, 2024 •

edited

Loading

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf7-dont-write-using-namespace-at-global-scope-in-a-header-file

Checklist before requesting a review

I have performed a self-review of my own code
I have verified that the code builds perfectly fine on my local system
I have added tests that prove my fix is effective or that my feature works
I have commented my code, particularly in hard-to-understand areas
I have verified that my code follows the style already available in the repository
I have made corresponding changes to the documentation


          Remove using namespace from global scope of header files

killenheladagen requested review from a team as code owners

August 30, 2024 15:00

madelen-at-work approved these changes

View reviewed changes

killenheladagen merged commit 3a061b0 into main

13 checks passed

killenheladagen deleted the rm-using-ns branch

September 9, 2024 12:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet