Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix choco endpoint. #85

Closed
wants to merge 3 commits into from
Closed

Fix choco endpoint. #85

wants to merge 3 commits into from

Conversation

Tatsinnit
Copy link
Member

@Tatsinnit Tatsinnit commented Oct 30, 2022

I found that the choco endpoitn was incorrect, so not sure if this got checked in but fyi @hsubramanianaks for double chekcing here is the fix PR and the choco endpoint: https://community.chocolatey.org/packages/dotnetcore-3.1-aspnetruntime

More details: #84

Thanks,

@Tatsinnit Tatsinnit requested a review from a team as a code owner October 30, 2022 20:46
@@ -130,7 +130,7 @@ install_tool() {
$PACKAGER tap isen-ng/dotnet-sdk-versions
install_with_sudo dotnet-sdk3-1-400 --cask
else
install_with_sudo aspnetcore-runtime-3.1
install_with_sudo dotnetcore-3.1-aspnetruntime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need add a condition for msys which is git bash or else wsl or Linux will break. Thank you for catching this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds like this should handle it?

Also, pkm choco reference - https://community.chocolatey.org/packages/dotnetcore-3.1-aspnetruntime

Please do recheck if previous was ever working. Or is this the case that aspnetcore-runtime-3.1 works for the ubuntu and not for the windows?

install_with_sudo() {
    if [[ $OSTYPE == "linux"* ]]; then
        sudo $PACKAGER install $1 -y
    else
        $PACKAGER install $2 $1
    fi
}

@hsubramanianaks
Copy link
Collaborator

Closing this PR, we will work on creating a new one from forked repo.

@elenavillamil elenavillamil deleted the fixinstallationchocoendpoint branch March 17, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants