Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deploy-Private-DNS-Zones - add DINE SqlServer PrivateDNSZone #1922

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

heintonny
Copy link

Overview/Summary

Add support for policy driven update of SQL Server Private DNS Zone group deployment.

This have been a Long term issue:
#1478
...who seems to never get prioritized because it also require a new azure built-in policy.

This PR depends on PR:
Azure/azure-policy#1418
get approved and merged to azure built-in policies:

This PR fixes/adds/changes/removes

  1. SQL Server Private DNS Zone group DINE policy

Breaking Changes

  1. None

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

Testing URLs

Policy Initiative is confirmed to work with EPAC deployment of the same policy definition and assignment file. Private DNS Zone is updated with DINE policy delays (several minutes).
image
image

Please also replace the curly brackets on the placeholders {}

Azure Public

[Deploy To Azure](https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2FHafslundEcoVannkraft%2FEnterprise-Scale%2F[feat/sql/private-dns-zone-dine](https://github.com/HafslundEcoVannkraft/Enterprise-Scale/tree/feat/sql/private-dns-zone-dine)%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2FHafslundEcoVannkraft%2FEnterprise-Scale%2F[feat/sql/private-dns-zone-dine](https://github.com/HafslundEcoVannkraft/Enterprise-Scale/tree/feat/sql/private-dns-zone-dine%2FeslzArm%2Feslz-portal.json)

Azure US Gov (Fairfax)

[Deploy To Azure](https://portal.azure.us/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2FeslzArm.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2F{YOUR GITHUB ORG/ACCOUNT HERE - Remove Curly Brackets Also}%2FEnterprise-Scale%2F{YOUR GITHUB BRANCH NAME HERE - Remove Curly Brackets Also}%2FeslzArm%2Ffairfaxeslz-portal.json)

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Ensured contribution guidance is followed.
  • Updated relevant and associated documentation.
  • Updated the "What's New?" wiki page (located: /docs/wiki/whats-new.md)

@heintonny
Copy link
Author

If Microsoft don´t plan to implement the SQL Server Private DNS Zone DINE as built-in policy I suggest that the policy is included as ALZ spesific policy definition as you did for other paas services earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant