Adding null check to handle rare NPE case #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TopicPartition for which no writer exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
In our deployment we rarely hit an NPE here, which typically results in duplicates due to the unhandled exception causing a premature exit from the
WorkerSinkTask.commitOffsetsmethod. In this failure mode we've already published batches to kusto, but we don't update the offsets due to an exception here.I have not yet fully understood how we get into this state, where a TopicPartitionWriter doesn't exist for a TopicPartition.
Future Release Comment
Fixed the source of a NullPointerException that could result in duplicate records sent to Kusto.
Breaking Changes:
Features:
Fixes: