Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Test-MgCommandPrerequisites.ps1 #40

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

BohrenAn
Copy link
Contributor

@BohrenAn BohrenAn commented Feb 3, 2024

Find-MgGraphCommand with API Version "beta" does not return anything. Therefore the Test-MgCommandPrerequisites Fails

Fixes #

Changes proposed in this pull request

Testing

Documentation

  • All exported commands have Synopsis, Parameter Descriptions, and at least one Example.

Other links

Find-MgGraphCommand with API Version "beta" does not return anything. Therefore the Test-MgCommandPrerequisites Fails
@BohrenAn
Copy link
Contributor Author

Created Issue in msgraph-sdk-powershell
microsoftgraph/msgraph-sdk-powershell#2582

The Parameter -APIVersion should not be used since Microsoft.Graph 2.x anymore. It's a leftover from 1.x

Regards
Andres

@BohrenAn
Copy link
Contributor Author

@merill Can someone please review this Pull request?

@merill merill merged commit 2fdc895 into AzureAD:main May 23, 2024
1 check passed
@merill
Copy link
Member

merill commented May 23, 2024

Thanks a lot for the PR @BohrenAn, sorry it took so long. Tx!

@SuryenduB
Copy link

This Merge is introducing new bug for the command Get-MsIdCrossTenantAccessActivity

GROUP\Documents\PowerShell\Modules\Microsoft.Graph.Authentication\2.23.0\custom\Find-MgGraphCommand.ps1:194 char:29
+ …             Write-Error "'$c' is not a valid Microsoft Graph PowerShe …
+               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@SuryenduB
Copy link

@merill @BohrenAn , can you please check this ?

@robbieveivers
Copy link
Contributor

image
image
Yeah i'd agree, we need to make sure this can work for both v1 and Beta command Searches.

Lucky only two commands are using Beta commands (Get-MsIdCrossTenantAccessActivity.ps, ConvertFrom-MsIdUniqueTokenIdentifier.ps1), hence why this bug has been not found.
image

Ill create a separate issue to work on this

@robbieveivers
Copy link
Contributor

Working off Issue #70
Test-MgCommandPrerequisites Must be able to handle v1 and beta via the APIVersion Parameter again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants