Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to buildsystem plugin to render dependencies in CG Manifest format #107

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

shahzaibj
Copy link
Contributor

@shahzaibj shahzaibj commented Jul 30, 2021

The plugin creates a custom task of type: DependencyReportTask that will render dependencies in CG Manifest format.

@shahzaibj shahzaibj changed the title Shahzaibj/print deps plugin Add support to buildsystem plugin to render dependencies in CG Manifest format Nov 11, 2021
@shahzaibj shahzaibj marked this pull request as ready for review November 11, 2021 03:56
@shahzaibj shahzaibj requested a review from a team as a code owner November 11, 2021 03:56
Copy link
Contributor

@AdamBJohnsonx AdamBJohnsonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment..

final String cgManifestPrettyJson = GSON.toJson(cgManifestJsonElement);

// log the JSON to console
System.out.println(cgManifestPrettyJson);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be configurable?

// First resolve the configuration
final ResolutionResult result = configuration.getIncoming().getResolutionResult();
// now render all dependencies in this configuration
result.allDependencies(dependencyResult -> renderDependencyResult(configuration, dependencyResult));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere there's a graph traversal... right? Looks like gradle handles that for you and just flattens the transitive list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants