Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release scripts and remove nativeauth submodule #364

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Update release scripts and remove nativeauth submodule #364

merged 6 commits into from
Feb 25, 2025

Conversation

p3dr0rv
Copy link
Contributor

@p3dr0rv p3dr0rv commented Feb 10, 2025 •
edited
Loading

Remove ADAL references
Update scripts to work on multi-platform
Update outdated steps

@p3dr0rv p3dr0rv requested a review from a team as a code owner February 10, 2025 23:50
@github-actions GitHub Actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

fadidurah
fadidurah approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@fadidurah fadidurah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why remove nativeauthsample?

@p3dr0rv p3dr0rv added the skip AB ID validation This PR does not require an AB ID item. label Feb 25, 2025
@p3dr0rv
Copy link
Contributor Author

p3dr0rv commented Feb 25, 2025

LGTM, but why remove nativeauthsample?

The submodule is not properly configured, all submodules need a submodule config file. So, I assume no one is using it.
That is why we have this SDL errors in daily and monthly release pipelines https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1435694&view=logs&j=9b83535e-dab5-52f1-8430-b3390f92c994&t=cc48085c-d335-5d99-e01d-1bd02ee28410

@p3dr0rv p3dr0rv merged commit 3b759a7 into master Feb 25, 2025
18 of 22 checks passed
@p3dr0rv p3dr0rv deleted the pedroro/update-scripts branch February 25, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fadidurah fadidurah fadidurah approved these changes

Assignees
No one assigned
Labels
skip AB ID validation This PR does not require an AB ID item.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p3dr0rv @fadidurah