Add ECDsa support in JsonWebKeyConverter.ConvertFromX509SecurityKey
#2379
+31
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keegan-caruso are you able to review this PR please? |
|
@joegoldman2 We'd really like to see tests on functional changes. Would it be possible to test this flow with an in-memory ECDsa key? |
|
I'm closing this PR in favor of #2377. I decided to merge both PRs because it is simpler to test the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2217.
I think the parameter
representAsRsaKeyshould probably be renamed to something else as EC will be supported. I am waiting for your feedback.