🕸️ [3/n] Null Accounts: Update Web to use CachedAuth #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-rader-msft
changed the base branch from
main
to
user/kyrader/null-accounts
kyle-rader-msft
force-pushed
the
user/kyrader/null-accounts-web
branch
from
345615c to
0d0a6cf
Compare
There was a problem hiding this comment.
My comments from #277 are also applicable here, but none of them are blocking.
kyle-rader-msft
force-pushed
the
user/kyrader/null-accounts
branch
from
34617fa to
8f5309d
Compare
kyle-rader-msft
force-pushed
the
user/kyrader/null-accounts-web
branch
from
0d0a6cf to
7429640
Compare
kyle-rader-msft
force-pushed
the
user/kyrader/null-accounts-web
branch
2 times, most recently
from
277c1eb to
4b2665a
Compare
shalinikhare27
approved these changes
Apr 26, 2023
reillysiemens
approved these changes
Apr 26, 2023
kyle-rader-msft
force-pushed
the
user/kyrader/null-accounts-web
branch
from
4b2665a to
5760c8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreReqs
Review #261
Update to use Cached Auth
This upgrades Web to use the Cached Auth.
I have re-ordered the test mocks to setup the mocks in the order we expect them to be called. This doesn't have a functional impact but I think makes reasoning about the tests easier.