Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 [4/n] Null Accounts: Update IWA to use CachedAuth #279

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

kyle-rader-msft
Copy link
Contributor

PreReqs

Review #261

Bug Fixes

  • The base bug fix of no longer collecting an extra msal ui required exception
  • IWA was previously not actually calling IWA in the event that cached auth returned null or timed out because neither of those are MSALUiRequired Exceptions.

@kyle-rader-msft kyle-rader-msft requested a review from a team as a April 20, 2023 18:18
@kyle-rader-msft kyle-rader-msft self-assigned this Apr 20, 2023
@kyle-rader-msft kyle-rader-msft added the bug Something isn't working label Apr 20, 2023
Copy link
Member

@reillysiemens reillysiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments from #277 apply here as well, otherwise I don't see any glaring issues.

@kyle-rader-msft kyle-rader-msft force-pushed the user/kyrader/null-accounts branch from 34617fa to 8f5309d Compare April 20, 2023 21:03
Base automatically changed from user/kyrader/null-accounts to main April 20, 2023 22:05
@kyle-rader-msft kyle-rader-msft force-pushed the user/kyrader/null-accounts-iwa branch from 4e15a83 to 3664f48 Compare April 21, 2023 07:33
@kyle-rader-msft kyle-rader-msft force-pushed the user/kyrader/null-accounts-iwa branch 2 times, most recently from 305d2e7 to d108cba Compare April 26, 2023 19:48
@kyle-rader-msft kyle-rader-msft force-pushed the user/kyrader/null-accounts-iwa branch from d108cba to 5370327 Compare April 26, 2023 21:18
@kyle-rader-msft kyle-rader-msft merged commit 5c47624 into main Apr 26, 2023
@kyle-rader-msft kyle-rader-msft deleted the user/kyrader/null-accounts-iwa branch April 26, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants