Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow portalocker version 3 #136

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

musicinmybrain
Copy link
Contributor

See https://github.com/wolph/portalocker/releases/tag/v3.0.0; portalocker 3 drops support for end-of-life Python versions older than 3.9. The older portalocker versions allowed in the range still cover these Python interpreter versions.

See https://github.com/wolph/portalocker/releases/tag/v3.0.0;
portalocker 3 drops support for end-of-life Python versions older than
3.9. The older portalocker versions allowed in the range still cover
these Python interpreter versions.
@rayluo
Copy link
Contributor

rayluo commented Jan 15, 2025

Thanks for your attempt. Have you also tested it with portalocker 3.0?

On the other hand, we intend to go another direction and remove portalocker altogether. You may want to help us test #117 instead.

@musicinmybrain
Copy link
Contributor Author

Thanks for your attempt. Have you also tested it with portalocker 3.0?

Well, I used tox to run the tests, and they all still passed. I don’t have any other ways to test this.

On the other hand, we intend to go another direction and remove portalocker altogether. You may want to help us test #117 instead.

It would seem that this PR still makes sense (though it will need to be rebased) even after #117 moves the portalocker dependency to an extra.

Again, I unfortunately don’t have anything to authenticate against or any particular experience with this library, and my ability to test this is limited to running tox.

This PR is motivated by the need to accommodate portalocker 3 in Fedora’s python-msal-extensions package.

@musicinmybrain
Copy link
Contributor Author

Note that dropping support for Python 3.9 is the only documented reason for portalocker bumping the major version, and the source diff wolph/portalocker@v2.10.1...v3.0.0 seems to agree; the changes look really minor.

@rayluo rayluo added the enhancement New feature or request label Jan 23, 2025
@rayluo rayluo merged commit 7a5d39e into AzureAD:dev Jan 23, 2025
18 of 20 checks passed
@rayluo rayluo mentioned this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants