-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom fragment logic - fulfill mReferencedFragment with intent.getExtras() #1704
base: dev
Are you sure you want to change the base?
Conversation
fulfill mReferencedFragment with intent.getExtras
Can someone review this pull request? |
I found the workaround. |
Can someone review this pull request? This PR resolves an important bug related to the use of fragments. |
Hi @VansonLeung! Can you review your PR? Looks like you need to fix this items: Thanks a lot! |
Hi @shoatman, @shahzaibj, @rpdome! Can you review this PR? The pipeline is waiting approval. This PR solves the issue AzureAD/microsoft-authentication-library-for-android#1725 A lot of thanks! |
Whats the current status of this fix? The work around does not work for release builds so we need this fix to go in as soon as possible. Many users are blocked |
This is an optimized pull request of the original one:
#1672
The custom fragment logic should fulfill the intent bundle parameters.
Otherwise "mReferencedFragment" has no state. Authentication will fail.