Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom fragment logic - fulfill mReferencedFragment with intent.getExtras() #1704

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

VansonLeung
Copy link

@VansonLeung VansonLeung commented Mar 26, 2022

This is an optimized pull request of the original one:
#1672

The custom fragment logic should fulfill the intent bundle parameters.
Otherwise "mReferencedFragment" has no state. Authentication will fail.

@VolodaUa
Copy link

Can someone review this pull request?
This issue is the blocker for a lot of users who can't use "withFragment" method.
I see you added as the reviewer
@shoatman
@shahzaibj
@rpdome

@VolodaUa
Copy link

I found the workaround.
Just create the same class in your project with the same package and Java runtime will use your class instead.

@LuisP89
Copy link

LuisP89 commented Nov 24, 2022

Can someone review this pull request?

This PR resolves an important bug related to the use of fragments.

@LuisP89
Copy link

LuisP89 commented Dec 29, 2022

Hi @VansonLeung! Can you review your PR? Looks like you need to fix this items:
image

Thanks a lot!

@VansonLeung VansonLeung requested a review from a team as a code owner December 30, 2022 08:26
@LuisP89
Copy link

LuisP89 commented Jan 3, 2023

Hi @shoatman, @shahzaibj, @rpdome!

Can you review this PR? The pipeline is waiting approval.
image

This PR solves the issue AzureAD/microsoft-authentication-library-for-android#1725

A lot of thanks!

@nikhil4coding
Copy link

Whats the current status of this fix? The work around does not work for release builds so we need this fix to go in as soon as possible. Many users are blocked

@VansonLeung
Copy link
Author

Whats the current status of this fix? The work around does not work for release builds so we need this fix to go in as soon as possible. Many users are blocked

It is still pending review

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants