DUNA flow: Resume Auth , Fixes AB#3079802 #2557
Conversation
…D/microsoft-authentication-library-common-for-android into pedroro/switch-to-browser
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3079802 to an Azure Boards work item. |
|
❌ Work item link check failed. Description contains AB#3079802 Click here to learn more. |
github-actions
bot
changed the title
...va/com/microsoft/identity/common/internal/providers/oauth2/AuthorizationActivityFactory.java
Show resolved
Hide resolved
| final boolean containsCode = extras.containsKey( | ||
| AuthenticationConstants.SWITCH_BROWSER.CODE | ||
| ); | ||
| return containsCode && containsActionUri; |
There was a problem hiding this comment.
Should we also check if the existing state of the authorization is it is waiting for resuming switch browser flow? You may want store some state what you can validate here.
| /** | ||
| * String Query parameter key to indicate support for SWITCH_BROWSER protocol. | ||
| */ | ||
| public static final String PATH = "switch_browser"; | ||
| public static final String CLAIM = "switch_browser"; |
There was a problem hiding this comment.
Why is this called CLAIM now?
There was a problem hiding this comment.
The previous constant called PATH was renamed to START_PATH (switch_browser) to differentiate it from RESUME_PATH (switch_browser_resume). The claim is the QP that indicates the client supports DUNA. Actually, I will rename it to CLIENT_SUPPORTS_FLOW.
This PR addresses step 16 of the Switch browser flow
BrokerBrowserRedirectActivity will re-start the WebViewAuthorizationFragment so we update the intent data and handle the activity being resumed on WebViewAuthorizationFragment.onResume
The switch browser resume endpoint requires the client ID, so we need to pass this value at the moment we start the WebAuthorizaFragment.
Refactor AuthorizationActivityFactory to work with one data parameter to create the auth intent.
AB#3079802