Add SsoExt identifier into MSIDDeviceInfo #1488
Conversation
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| @@ -69,6 +69,7 @@ extern NSString * _Nonnull const MSID_BROKER_DEVICE_MODE_KEY; | |||
| extern NSString * _Nonnull const MSID_BROKER_SSO_EXTENSION_MODE_KEY; | |||
There was a problem hiding this comment.
This pull request does not update changelog.txt.
Please consider if this change would be noticeable to a partner or user and either update changelog.txt or resolve this conversation.
| @@ -55,6 +55,12 @@ typedef NS_ENUM(NSInteger, MSIDPreferredAuthMethod) | |||
| MSIDPreferredAuthMethodQRPIN | |||
| }; | |||
|
|
|||
| typedef NS_ENUM(NSInteger, MSIDSsoProviderType) | |||
There was a problem hiding this comment.
Would it be beneficial to make this enum available in a separate header file?
There was a problem hiding this comment.
There are other enums in this file as of today, we can move out when more enums coming for better management
|
|
||
| - (MSIDSsoProviderType)ssoProviderTypeEnumFromString:(NSString *)deviceModeString | ||
| { | ||
| if ([deviceModeString isEqualToString:@"companyPortal"]) return MSIDCompanyPortalSsoProvider; |
There was a problem hiding this comment.
Create a static dictionary <string, MSIDSsoProviderType> instead of if statements and return value for key. Return unknown by default in no matching key
There was a problem hiding this comment.
Hi @ameyapat, cannot put MSIDSsoProviderType into dictionary as NSInteger is not supported neither as a key or value. I can convert MSIDSsoProviderType value to an NSNumber and save it into a dict, let me know.
Co-authored-by: Ameya Patil <[email protected]>
Proposed changes
This is to add a new filed to return SsoExtension type
Type of change
Risk
Additional information