Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise hashing at NSData and NSString extensions #149

Closed
wants to merge 1 commit into from

Conversation

unpluggedk
Copy link
Contributor

  • Remove hashing from NSString extensions
  • Add convenience converting method for NSString -> NSData
  • Modify NSData extensions to handle hashing, modulized.
  • Add stringify methods to NSData.

example calls

NSString *sha256Hex = @"string".msidData.msidSHA256.hexString;
NSString *sha256Base64 =  @"string".msidData.msidSHA256.base64EncodedString;
NSString *sha256Base64UrlEncoded = @"string".msidData.msidSHA256.base64EncodedString.mdmsidBase64UrlEncode;

@unpluggedk
Copy link
Contributor Author

Addresses #147

Copy link
Member

@oldalton oldalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but would you mind adding some tests to this. Based on your changes it looks like we didn't have any tests for it before :) e.g. a couple of tests for hex string

@oldalton oldalton added this to the msal_0.1.5 milestone Jul 29, 2018
@unpluggedk unpluggedk mentioned this pull request Sep 5, 2018
@unpluggedk
Copy link
Contributor Author

#221 should address this

@unpluggedk unpluggedk closed this Sep 5, 2018
@unpluggedk unpluggedk deleted the jak/decouple-hashing-stringify branch September 5, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants