Updates for shared device mode testing #1625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shoatman
commented
May 22, 2022
shoatman
commented
- Added shared device mode configuration file
- Added registerReceiver, unRegisterReceiver
Codecov Report
@@ Coverage Diff @@
## dev #1625 +/- ##
=========================================
Coverage 49.37% 49.37%
Complexity 372 372
=========================================
Files 59 59
Lines 2708 2708
Branches 333 333
=========================================
Hits 1337 1337
Misses 1227 1227
Partials 144 144 Continue to review full report at Codecov.
|
shahzaibj
reviewed
May 24, 2022
| "redirect_uri" : "msauth://com.msft.identity.client.sample.local/1wIqXSqBj7w%2Bh11ZifsnqwgyKrY%3D", | ||
| "handle_null_taskaffinity": true, | ||
| "authorization_in_current_task": false, | ||
| "shared_device_mode_supported": true, |
There was a problem hiding this comment.
What does this do? Or I guess what happens when we don't add this or add this and set to false? I'm asking because I thought MSAL Test App was already working with Shared Device.
bktowett
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.