Updating exceptions for 404 to include authority #5095
Merged
+116
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Jan 22, 2025
src/client/Microsoft.Identity.Client/MsalServiceExceptionFactory.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jan 22, 2025
src/client/Microsoft.Identity.Client/MsalServiceExceptionFactory.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jan 22, 2025
tests/Microsoft.Identity.Test.Unit/ExceptionTests/MsalExceptionTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Jan 22, 2025
|
Using the endpoint was a mistake, however, do we want to add it anyway?, alongside the authority in the exception for 404? |
bgavrilMS
reviewed
Jan 22, 2025
added 2 commits
January 22, 2025 22:12
bgavrilMS
approved these changes
Jan 27, 2025
gladjohn
reviewed
Jan 28, 2025
src/client/Microsoft.Identity.Client/MsalServiceExceptionFactory.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Jan 28, 2025
gladjohn
approved these changes
Jan 28, 2025
gladjohn
approved these changes
Jan 29, 2025
|
This has been signed off @trwalke - please merge it |
@bgavrilMS the builds were all failing since Monday, was waiting for them to be fixed. Seems like they are working now. Merging when pr build is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Fix for #4769
Changes proposed in this request
Authority will be appended to exception messages when 404 is encountered.
Testing
Unit.
Performance impact
Documentation