Expose client capabilities in AssertionRequestOptions for MSI FIC scenarios #5140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trwalke
reviewed
Feb 12, 2025
...crosoft.Identity.Client/Internal/ClientCredential/SignedAssertionDelegateClientCredential.cs
Show resolved
Hide resolved
trwalke
reviewed
Feb 13, 2025
src/client/Microsoft.Identity.Client/AppConfig/AssertionRequestOptions.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 13, 2025
...crosoft.Identity.Client/Internal/ClientCredential/SignedAssertionDelegateClientCredential.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 13, 2025
src/client/Microsoft.Identity.Client/AppConfig/AssertionRequestOptions.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 13, 2025
src/client/Microsoft.Identity.Client/AppConfig/AssertionRequestOptions.cs
Show resolved
Hide resolved
bgavrilMS
requested changes
Feb 13, 2025
gladjohn
force-pushed
the
gladjohn/assertion_options
branch
from
92f81fe to
41e6d29
Compare
bgavrilMS
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4948
Changes proposed in this request
This pull request introduces new functionality to handle client capabilities in the
Microsoft.Identity.Clientlibrary. The changes include updates to theAssertionRequestOptionsclass, modifications to theSignedAssertionDelegateClientCredentialclass to utilize these capabilities, and corresponding updates to the public API and unit tests.New functionality for client capabilities:
src/client/Microsoft.Identity.Client/AppConfig/AssertionRequestOptions.cs: Added a new property,ClientCapabilities, to theAssertionRequestOptionsclass. This property allows client applications to declare capabilities in the assertion.Modifications to handle client capabilities:
src/client/Microsoft.Identity.Client/Internal/ClientCredential/SignedAssertionDelegateClientCredential.cs: Updated theAddConfidentialClientParametersAsyncmethod to conditionally set theClientCapabilitiesproperty in theAssertionRequestOptionsobject if they exist and are not empty.Public API updates:
src/client/Microsoft.Identity.Client/PublicApi/net462/PublicAPI.Unshipped.txt: Added getter and setter entries for the newClientCapabilitiesproperty.src/client/Microsoft.Identity.Client/PublicApi/net472/PublicAPI.Unshipped.txt: Added getter and setter entries for the newClientCapabilitiesproperty.src/client/Microsoft.Identity.Client/PublicApi/net8.0-android/PublicAPI.Unshipped.txt: Added getter and setter entries for the newClientCapabilitiesproperty.src/client/Microsoft.Identity.Client/PublicApi/net8.0-ios/PublicAPI.Unshipped.txt: Added getter and setter entries for the newClientCapabilitiesproperty.src/client/Microsoft.Identity.Client/PublicApi/net8.0/PublicAPI.Unshipped.txt: Added getter and setter entries for the newClientCapabilitiesproperty.src/client/Microsoft.Identity.Client/PublicApi/netstandard2.0/PublicAPI.Unshipped.txt: Added getter and setter entries for the newClientCapabilitiesproperty.Unit tests:
tests/Microsoft.Identity.Test.Unit/PublicApiTests/ConfidentialClientApplicationTests.cs: Updated theCreateConfidentialClientmethod to accept awithClientCapabilityparameter and conditionally set the client capabilities. Added a new test method,SignedAssertionWithClientCapabilitiesTestAsync, to verify the functionality when client capabilities are set. [1] [2] [3]Testing
unit tests
Performance impact
none
Documentation