Add the missing claims in SignedAssertion With AssertionRequestOptions Delegate #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
bgavrilMS
reviewed
Feb 18, 2025
...crosoft.Identity.Client/Internal/ClientCredential/SignedAssertionDelegateClientCredential.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5143
Changes proposed in this request
This pull request introduces changes to the
SignedAssertionDelegateClientCredentialclass to handle client capabilities and claims more effectively, and adds corresponding unit tests to verify these changes.Improvements to handling client capabilities and claims:
src/client/Microsoft.Identity.Client/Internal/ClientCredential/SignedAssertionDelegateClientCredential.cs: Simplified the logic for setting client capabilities and added a new section to set claims within theAddConfidentialClientParametersAsyncmethod.Unit tests for new functionality:
tests/Microsoft.Identity.Test.Unit/PublicApiTests/ConfidentialClientApplicationTests.cs: Added three new test methods (SignedAssertionDelegateClientCredential_Claims_TestAsync,SignedAssertionDelegateClientCredential_NoClaims_TestAsync, andSignedAssertionDelegateClientCredential_WithClaims_TestAsync) to ensure that claims are correctly handled when acquiring tokens with or without claims.Testing
Unit tests
Performance impact
none
Documentation