Adding FMI Integration tests #5149
Draft
+441
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trwalke
commented
Feb 19, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/FmiIntegrationTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 19, 2025
| [TestClass] | ||
| public class FmiIntegrationTests | ||
| { | ||
| private const string _fmiAppUrn = "urn:microsoft:identity:fmi"; |
There was a problem hiding this comment.
style for constants is different I believe. SomeConstant
There was a problem hiding this comment.
We should add an analyzer for it
There was a problem hiding this comment.
It exists as suggestion today, I agree the UI isn't very clear about it (the 3 little dots0
You can make it a warning in the .editorconfig.
bgavrilMS
reviewed
Feb 19, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/FmiIntegrationTests.cs
Outdated
Show resolved
Hide resolved
added 3 commits
February 19, 2025 14:50
bgavrilMS
reviewed
Feb 21, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/FmiIntegrationTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 21, 2025
| .ExecuteAsync() | ||
| .ConfigureAwait(false); | ||
|
|
||
| MsalAssert.AssertAuthResult(authResult); |
There was a problem hiding this comment.
What you should really assert on is:
- the cache key (internal and external)
- the sub claim of the token
- the aud claim of the token
- other claims?
So I suggest you do all the checks inline.
bgavrilMS
reviewed
Feb 21, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/FmiIntegrationTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 21, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/FmiIntegrationTests.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 21, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/FmiIntegrationTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 21, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/FmiIntegrationTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 21, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/FmiIntegrationTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 21, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/FmiIntegrationTests.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 21, 2025
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/FmiIntegrationTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
requested changes
Feb 21, 2025
trwalke
commented
Feb 26, 2025
| "expectedAudience"); | ||
| } | ||
|
|
||
| private static async Task<string> GetParentCredential(AssertionRequestOptions options) |
There was a problem hiding this comment.
Added the assertion logic to a private method. It seemed like too much code to have this in every test. This is also how JM has it in his spec
bgavrilMS
reviewed
Feb 28, 2025
| .BuildConcrete(); | ||
|
|
||
| //Configure token cache serialization | ||
| confidentialApp.AppTokenCache.SetBeforeAccess(BeforeCacheAccess); |
There was a problem hiding this comment.
Can you pls use the static cache here? And update the TestBase to delete the static cache on every test.
bgavrilMS
reviewed
Feb 28, 2025
|
|
||
| //Fmi app/scenario parameters | ||
| var clientId = "4df2cbbb-8612-49c1-87c8-f334d6d065ad"; | ||
| var scope = "api://AzureFMITokenExchange/.default"; |
There was a problem hiding this comment.
nit: no reason for these variables.
bgavrilMS
reviewed
Feb 28, 2025
| namespace Microsoft.Identity.Test.Integration.NetCore.HeadlessTests | ||
| { | ||
| /// <summary> | ||
| /// The tests in this file are demonstrations of the various authentication flows outlined in the "FMI protocol spec v1.0" Section 3.2 |
There was a problem hiding this comment.
Suggested change
| /// The tests in this file are demonstrations of the various authentication flows outlined in the "FMI protocol spec v1.0" Section 3.2 | |
| /// The tests in this file are demonstrations of the various authentication flows outlined in the "FMI protocol spec v1.0" Section 3.2 | |
| /// https://microsoft.sharepoint.com/:w:/t/aad/protocols/EThMH6es0UNKhsFlVgBiBegByuZQ6CnaCzzAdAV0excHVA?e=m5xXtV |
bgavrilMS
reviewed
Feb 28, 2025
|
|
||
| //Fmi app/scenario parameters | ||
| var clientId = "4df2cbbb-8612-49c1-87c8-f334d6d065ad"; | ||
| var scope = "022907d3-0f1b-48f7-badc-1ba6abab6d66/.default"; |
There was a problem hiding this comment.
nit: Maybe add a comment of what this resource represents
bgavrilMS
reviewed
Feb 28, 2025
|
|
||
| //Acquire Token | ||
| var authResult = await confidentialApp.AcquireTokenForClient(new[] { scope }) | ||
| .WithFmiPath("SomeFmiPath/Path") //Sets fmi path in client credential request. |
There was a problem hiding this comment.
We should have a different FMI path for the credential.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this request
Testing
Performance impact
Documentation