-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do Not Merge] Bump up the WebView2 package version #5154
base: main
Are you sure you want to change the base?
Conversation
@DharshanBJ please add a bug, and the reason to bump the version |
Updated the PR description with the reasoning for this fix and shared a link to the github issue. |
LGTM, pls close all the comments and merge. |
@DharshanBJ - we are aiming for a release today. I would merge this for you, but the title says otherwise. If you want to catch this release, pls merge. |
@bgavrilMS , i was running into some issues when i tested this on the older dotnet versions. So i'll run a few more tests to ensure this change won't regress anything. |
added the do not merge label |
The Microsoft.Identity.Client.Desktop package relies on an older version of the Microsoft.Web.WebView2 library (version 1.0.864.35, released on June 1st, 2021). However, the DLL structure has changed between version 1.0.864.35 and the latest versions of the WebView2 package. Specifically, version 1.0.864.35 uses the Microsoft.Web.WebView2.Core dll, while the newer versions have Microsoft.Web.WebView2.Core.Projection dll.
Please see internals of packages
https://www.nuget.org/packages/Microsoft.Web.WebView2/1.0.864.35#versions-body-tab
https://nuget.info/packages/Microsoft.Web.WebView2/1.0.864.35
https://nuget.info/packages/Microsoft.Web.WebView2/1.0.2903.40
This change in the DLL structure likely leads to a binary/API incompatibility between the older version of WebView2 and Maui 9, resulting in the following exception when users upgrade to Maui 9:
"Could not load file or assembly 'Microsoft.Web.WebView2.Core, Version=1.0.864.35, Culture=neutral, PublicKeyToken=2a8ab48044d2601e'. The system cannot find the file specified."
I was able to reproduce this issue in a sample app from one of the users who reported it. The problem is resolved by updating the WebView2 version in Directory.Packages.props to a newer version that uses the updated DLL structure.
Fixes #4933