Update benchmark-action.yml to use NET 8 #5157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
changed the title
bgavrilMS
reviewed
Feb 28, 2025
| - name: Run benchmark | ||
| run: cd tests/Microsoft.Identity.Test.Performance && dotnet run -c release -f net6.0 --exporters json | ||
| run: cd tests/Microsoft.Identity.Test.Performance && dotnet run -c release -f net8.0 --exporters json |
There was a problem hiding this comment.
Why don't we delete it instead? Are we using this?
There was a problem hiding this comment.
afaik we are using it, tagging @pmaytak to confirm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5159
Changes proposed in this request
This pull request includes updates to the
.github/workflows/benchmark-action.ymlfile to ensure compatibility with the latest .NET version.Updates to
.github/workflows/benchmark-action.yml:dotnet-versionfrom6.0.418to8.0.xto use the latest .NET version.net6.0tonet8.0to align with the updated .NET version.Testing
build
Performance impact
none
Documentation